readd screen reading ban, split mod file reading from vanilla file reading, define & restrict resetting mods#171
Open
tildejustin wants to merge 18 commits intoMinecraft-Java-Edition-Speedrunning:v6from
Conversation
65ad728 to
22b3cd7
Compare
22b3cd7 to
3f82af3
Compare
r0hkx
requested changes
Jul 20, 2025
r0hkx
requested changes
Jul 21, 2025
r0hkx
previously approved these changes
Jul 25, 2025
…th fast reset is now (and always was) blanket banned outside resetting so this is obviously implied, nothing special about glitched
r0hkx
requested changes
Aug 5, 2025
Member
r0hkx
left a comment
There was a problem hiding this comment.
please don't add random other changes to existing prs, just make another pr
f638760 to
c62c414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is sidestepping both rethinking how much of mod file reading is allowed (which in theory should also ban this), as well as significantly clarifying to the point of rewriting the remapping rules, but this change can stand on its own and does not need to wait for those which will take much longer.